Our dba team noted that the SQL that is used to setup AppInsight for SQL will work for existing databases in the instance.
However if there is a new db created, part of the SQL script would need to be re-ran.
They have made the following suggestion:
Change
EXECUTE sp_MSforeachdb 'USE [?]; EXEC sp_adduser @loginame = ''AppInsightUser'', @name_in_db = ''AppInsightUser'''
to
use [master]
GRANT VIEW ANY DATABASE TO [AppInsightUser]
Comments / Concerns / Observations please.
Chris.