Powershell Component with Multiple Statistics

Just grasping at straws here.  Make sure the powershell exits with return code 0.  Basically to test it, wrap the entire thing in a giant try/catch and in the catch part maybe write out "statistic.error: 1"

I found some time to test this theory.  It seems partially plausible, but incomplete.  In my test I did the output and caused an exception.  Output section showed my output.  The "Dynamic Monitor Result Info:" section was blank, and the "Outcome based on statistic thresholds:" is Undefined.  So that matches... BUT... the exception shows up in the "Errors: " section, where yours didn't show anything.

I don't suppose you actually have the "exit" command in the script anywhere do you?

I tried wrapping it in a try/catch and I'm getting the same "Not Defined" error for the output. This is the script.

try {
    $credential = Get-Credential -Credential '${CREDENTIAL}'
    $username = $credential.GetNetworkCredential().username
    $password = $credential.GetNetworkCredential().password

    $baseUrl = "https://yyy.yyy.yyy.yyy:8000"
    $authHeader = [Convert]::ToBase64String([Text.Encoding]::ASCII.GetBytes("$username:$password"))
    $headers = @{ "Content-Type" = "application/json"; "Authorization" = "Basic $authHeader" }

    $metrics = @(
        "pkt4-received",
        "pkt4-ack-received",
        "pkt4-ack-sent",
        "pkt4-discover-received",
        "pkt4-offer-sent",
        "pkt4-nak-received",
        "pkt4-request-received"
    )

    $metricDescriptions = @{
        "pkt4-received" = "Packets Received"
        "pkt4-ack-received" = "ACKs Received"
        "pkt4-ack-sent" = "ACKs Sent"
        "pkt4-discover-received" = "Discover Packets Received"
        "pkt4-offer-sent" = "Offers Sent"
        "pkt4-nak-received" = "NAKs Received"
        "pkt4-request-received" = "Requests Received"
    }

    foreach ($metric in $metrics) {
        $payload = @{ 
            "command" = "statistic-get"
            "service" = @("dhcp4")
            "arguments" = @{ "name" = $metric }
        } | ConvertTo-Json

        try {
            $response = Invoke-RestMethod -Uri $baseUrl -Method Post -Headers $headers -Body $payload
            $latestValue = $response.arguments."$metric"[0]
            $value, $timestamp = $latestValue -split " "
            $metricName = $metric -replace '-', ''
            $description = $metricDescriptions[$metric]
            Write-Host "Statistic.${metricName}: $value"
            Write-Host "Message.${metricName}: $description"
        } catch {
            Write-Host "Error for ${metric}: $_"
        }
    }

    Write-Host "Statistic.Test: 1"
    Write-Host "Message.Test: Test"
    exit 0
} catch {
    Write-Host "Script failed: $_"
    exit 1
}

I tried wrapping it in a try/catch and I'm getting the same "Not Defined" error for the output. This is the script.

try {
    $credential = Get-Credential -Credential '${CREDENTIAL}'
    $username = $credential.GetNetworkCredential().username
    $password = $credential.GetNetworkCredential().password

    $baseUrl = "https://yyy.yyy.yyy.yyy:8000"
    $authHeader = [Convert]::ToBase64String([Text.Encoding]::ASCII.GetBytes("$username:$password"))
    $headers = @{ "Content-Type" = "application/json"; "Authorization" = "Basic $authHeader" }

    $metrics = @(
        "pkt4-received",
        "pkt4-ack-received",
        "pkt4-ack-sent",
        "pkt4-discover-received",
        "pkt4-offer-sent",
        "pkt4-nak-received",
        "pkt4-request-received"
    )

    $metricDescriptions = @{
        "pkt4-received" = "Packets Received"
        "pkt4-ack-received" = "ACKs Received"
        "pkt4-ack-sent" = "ACKs Sent"
        "pkt4-discover-received" = "Discover Packets Received"
        "pkt4-offer-sent" = "Offers Sent"
        "pkt4-nak-received" = "NAKs Received"
        "pkt4-request-received" = "Requests Received"
    }

    foreach ($metric in $metrics) {
        $payload = @{ 
            "command" = "statistic-get"
            "service" = @("dhcp4")
            "arguments" = @{ "name" = $metric }
        } | ConvertTo-Json

        try {
            $response = Invoke-RestMethod -Uri $baseUrl -Method Post -Headers $headers -Body $payload
            $latestValue = $response.arguments."$metric"[0]
            $value, $timestamp = $latestValue -split " "
            $metricName = $metric -replace '-', ''
            $description = $metricDescriptions[$metric]
            Write-Host "Statistic.${metricName}: $value"
            Write-Host "Message.${metricName}: $description"
        } catch {
            Write-Host "Error for ${metric}: $_"
        }
    }

    Write-Host "Statistic.Test: 1"
    Write-Host "Message.Test: Test"
    exit 0
} catch {
    Write-Host "Script failed: $_"
    exit 1
}

Did you see the "statistic.test: 1" in the output?

Beacuse if you saw that, then we are going down the wrong path.

This is probably not the case here, but just to reiterate.  I personally recommend to never use an exit code, and if you use the exit command always "exit 0".  The reason is that you are forcibly setting the result of the monitor regardless of the thresholds you might have set.  See: 

https://documentation.solarwinds.com/en/success_center/sam/content/sam-script-report-status-through-exit-codes.htm

I prefer to allow the thresholds to set the status.  if you specify exit 0, the thresholds can override that, but not the other exit values.

Nope.

Ok that is confusing.  If you see the other output but not the statistic.test, then it's crashing between there...but where?  I don't see anything that could cause it.

how about you change the catch to:

Write-Host "Statistic.error: 1"
Write-Host "Message.error: $_"

Maybe that way it will let you see the error message.

Still Not Defined. I don't think the script is the problem.

ok, that's no output result.  I thought you were talking about somewhere else.  Save that and go back to the previous screen, check the component and click test.  Lets see that output

did you try swapping the order of message and statistic in the write-output? 

I second the case of using only exit 0 UNLESS the script itself fails.  Like it requiring an argument or something like that.  

Just tested it. It made no difference.

Everything is exactly right... except for the status.  You have a really odd one here.

So the basics... reboot node, reboot solarwinds, disable anti hacking stuff on the node (trend/crowdstrick/etc).

Create a new monitor with nothing except below, but everything else the same.

write-host "statistic: 0"

Write-host "message: working"

does this work?