Open for Voting

Fixing email validation check on Reply address

I hope that email validation check would be fixed so that variables could be also used.

I think this is a fix for a bug, not request, I'll explain it later in this message.

Here's link to original question: https://thwack.solarwinds.com/thread/101145

Case #984672 has been opened relating to this problem.

I found temporary solution to fix email check:

  • Find your Orion web site files (with default install C:\inetpub\SolarWinds\Orion)
  • Navigate to Actions\js folder
  • Locate file: EmailController.js
  • Right click on file and choose Edit.
  • Locate line:

var regex = /^([a-zA-Z0-9_.+-~/&\*\'\?\!\#\^\{\}])+\@(([a-zA-Z0-9-])+\.)+([a-zA-Z0-9]{2,4})+$/;

  • Add \$ after \}, line should look like this after change:

var regex = /^([a-zA-Z0-9_.+-~/&\*\'\?\!\#\^\{\}\$])+\@(([a-zA-Z0-9-])+\.)+([a-zA-Z0-9]{2,4})+$/;

  • Save file.
  • What we just do?:
    • We added dollar sign as accepted character in email validation.
  • Test that change works:
    • Empty your browser cache for preventing loading old version of js file.
    • Login to Orion Website
    • Edit alert action and try to add variable ínstead of normal email.

Reminder: When running Configuration Wizard with re-installing Web Services, EmailController.js will be overwritten and change must be done again.

More "permanent solution" is of course to change EmailController.js file in NetPerfMon-WebSite.zip and zip it again, but I'm happy with this fix emoticons_happy.png

Why I think is a bug:

Email validation has already curly brackects in regex rule.

Curly brackects are used only in variables, not in normal emails.

So if there would be only fixed email check, regex rule wouldn't have curly brackets in first place.

Dollar sign has just been forgotten from regex rule.